Format: Intl readable datetime rewrite usages #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dateIntlReadable to replace dateReadable * dateTimeIntlReadable to replace dateTimeReadable * Add test coverage to Format::dateTimeReadable, Format::dateIntlReadable and Format::dateTimeIntlReadable.
Refactor with unit test verification * modules/Planner/units_edit_deploy.php * modules/Students/student_view_details.php
Refactor with unit test verification * modules/Attendance/attendance_future_byPerson.php
Refactor with unit test verification * modules/Attendance/report_graph_byType.php
Refactor with unit test verification * modules/Attendance/attendance.php * modules/Attendance/report_courseClassesNotRegistered_byDate_print.php * modules/Attendance/report_formGroupsNotRegistered_byDate_print.php * modules/Attendance/report_formGroupsNotRegistered_byDate.php * modules/Attendance/src/AttendanceView.php refactor: dateIntlReadable refactor 2 Refactor with unit test verification * modules/Attendance/report_courseClassesNotRegistered_byDate.php
Changes that default format tests already cover:
* modules/Admissions/src/Forms/ApplicationMilestonesForm.php
* modules/Reports/archive_byStudent_view.php
* modules/Reports/reporting_access_manage.php
* modules/System Admin/import_manage.php
* modules/Timetable/report_viewAvailableSpace_view.php
* modules/Timetable/report_viewAvailableTeachers_view.php
refactor: dateIntlReadable refactor 5
* modules/Staff/src/Messages/NewAbsenceWithCoverage.php
Refactor with unit test verification * modules/Reports/reporting_my.php * modules/Activities/report_attendance.php
Refactor with unit test verification * modules/Staff/src/Forms/CoverageRequestForm.php
Refactor with unit test verification * modules/Activities/activities_attendance.php
Refactor with unit test verification * modules/Staff/src/Tables/AbsenceCalendar.php
Refactor with unit test verification * modules/Staff/src/Tables/CoverageDates.php
Refactor with unit test verification * modules/Staff/src/Tables/CoverageCalendar.php
Refactor with unit test verification * modules/Staff/src/Messages/CoveragePartial.php
Refactor with unit test verification * modules/Staff/report_subs_availability.php
Refactor with unit test verification * modules/Staff/coverage_my.php
Refactor with unit test verification * modules/Staff/report_coverage_summary.php
Refactor with unit test verification * modules/Staff/coverage_planner.php
Refactor with unit test verification * modules/Staff/report_absences_weekly.php
Refactor with unit test verification * modules/Staff/report_subs_availabilityWeekly.php
Refactor with unit test verification * modules/Planner/units_edit_working.php
Refactor with unit test verification * modules/Staff/report_absences_summary.php
Changes that default format tests already cover: * modules/Admissions/admissions_manage_edit.php * modules/Reports/archive_byReport.php * modules/Reports/reporting_cycles_manage.php * modules/Reports/templates/reports/coverPage.twig.html * modules/Reports/templates/reports/footers/signatureBox.twig.html * modules/Reports/templates/reports/footers/signatureLine.twig.html * modules/Reports/templates/reports/headers/reportInfo.twig.html * modules/Reports/templates/reports/studentDetails.twig.html * modules/Reports/templates/ui/reportingCycleHeader.twig.html * modules/Staff/coverage_availability.php * modules/Staff/coverage_manage_addAjax.php * modules/Staff/coverage_planner_assign.php * modules/Staff/src/Forms/CoverageRequestForm.php * modules/Staff/src/Tables/AbsenceDates.php
Refactor with unit test verification * modules/Reports/templates/ui/reportingCycleHeader.twig.html * modules/Staff/coverage_planner_assign.php
* Use Format::dateTimeIntlReadable to replace all basic Format::dateTimeReadable usages (without specified formatting string).
* Use Format::dateIntlReadable to replace all advance Format::dateTimeReadable usages. * Add unit test for fidelity checks.
SKuipers
force-pushed
the
feat/intl-readable-datetime-rewrite-usages
branch
from
82b5cf2
to
2520839
Compare
SKuipers
changed the title
SKuipers
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note that the formatting strign '%e' (day of month with leading space) has no equivlant in intl module. They are all rewritten with 'd' formatter, which is only the digit without leading space. These are all the occurrence of such '%e' refactors:
Motivation and Context
How Has This Been Tested?