-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce dependency on getdkan/contracts (part 1) #4177
Draft
paul-m
wants to merge
22
commits into
2.x
Choose a base branch
from
no-contracts
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-m
changed the title
Remove dependency on getdkan/contracts
Reduce dependency on getdkan/contracts (part 1)
May 13, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3821
\Contracts\CountableInterface
\Countable
\Contracts\HydratableInterface
\Procrastinator\HydratableInterface
\Contracts\ParserInterface
\CsvParser\Parser\ParserInterface
\Contracts\RetrieverInterface
and\Contracts\StorerInterface
remain ingetdkan/contracts
because there is no clear place to move them. They're needed within multiple libraries. Refactor this in a followup.We also need to keep
getdkan/contracts
as a dependency in many places because some libraries useContracts\Mock\Storage\Memory
for tests. Refactor this in a followup.Our changes to
Drupal\common\Storage\Query
... See the @todo which asks if we should just make a QueryInterface.In order to make all these changes, we have to modify the following libraries, maybe in this order.
Each PR is a branch named
no-contracts
, some of which have interdependencies on each other. These PRs will need to be updated to require the release of each of these dependencies.getdkan/contracts
getdkan/csv-parser
getdkan/contracts
after PR.getdkan/procrastinator
StorerInterface
andRetrieverInterface
. We need to figure out where to put storage-related interfaces in round 2 of this refactor.getdkan/file-fetcher
Contracts\Mock\Storage\Memory
for testing. Refactor in round 2.getdkan/harvest
Contracts\Mock\Storage\Memory
for testing. Refactor in round 2.