Rip out innodb_strict_mode switch (#3887)

GetDKAN · Dec 14, 2022 · cfcd55c · cfcd55c
1 parent d0b1bee
commit cfcd55c
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 66 deletions.
diff --git a/modules/datastore/modules/datastore_mysql_import/src/Service/MysqlImport.php b/modules/datastore/modules/datastore_mysql_import/src/Service/MysqlImport.php
@@ -58,10 +58,7 @@ protected function runIt() {
     $spec = $this->generateTableSpec($columns);
     $this->dataStorage->setSchema(['fields' => $spec]);
 
-    // @todo Find a better way to ensure creation of datastore tables.
-    $this->dataStorage->innodbStrictMode(FALSE);
     $this->dataStorage->count();
-    $this->dataStorage->innodbStrictMode(TRUE);
     // Construct and execute a SQL import statement using the information
     // gathered from the CSV file being imported.
     $this->getDatabaseConnectionCapableOfDataLoad()->query(

diff --git a/modules/datastore/src/Storage/DatabaseTable.php b/modules/datastore/src/Storage/DatabaseTable.php
@@ -6,7 +6,6 @@
 use Drupal\datastore\DatastoreResource;
 use Drupal\common\LoggerTrait;
 use Drupal\common\Storage\AbstractDatabaseTable;
-use Drupal\Core\Database\Driver\mysql\Connection as MysqlConnection;
 
 /**
  * Database storage object.
@@ -167,20 +166,6 @@ public function setSchema($schema): void {
     parent::setSchema($schema);
   }
 
-  /**
-   * Disable/enable InnoDB strict mode for the given database connection.
-   *
-   * @param bool $on
-   *   Whether strict mode should be "ON" or "OFF".
-   */
-  public function innodbStrictMode(bool $on) {
-    $value = $on ? "ON" : "OFF";
-    // Only if we're using MySQL.
-    if ($this->connection instanceof MysqlConnection) {
-      $this->connection->query("SET SESSION innodb_strict_mode=:value", [':value' => $value]);
-    }
-  }
-
   /**
    * Get the table schema in Drupal Schema API format.
    *

diff --git a/modules/datastore/tests/src/Functional/Storage/DatabaseTableTest.php b/modules/datastore/tests/src/Functional/Storage/DatabaseTableTest.php
diff --git a/modules/metastore/modules/metastore_search/src/Plugin/DkanApiDocs/MetastoreSearchApiDocs.php b/modules/metastore/modules/metastore_search/src/Plugin/DkanApiDocs/MetastoreSearchApiDocs.php
@@ -15,6 +15,8 @@
  *  id = "metastore_search_api_docs",
  *  description = "Search docs"
  * )
+ *
+ * @codeCoverageIgnore
  */
 class MetastoreSearchApiDocs extends DkanApiDocsBase {