-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Unpin geopandas in the Docs workflow and manually register gdal drivers as workaround #3305
base: main
Are you sure you want to change the base?
Changes from 8 commits
975e309
0048ede
ff0b55f
54ad797
979f228
c68f7ee
1d81bfe
8dfd10c
9883359
b403e6e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -101,7 +101,7 @@ jobs: | |
netCDF4 | ||
packaging | ||
contextily | ||
geopandas<1.0 | ||
geopandas | ||
ipython | ||
rioxarray | ||
build | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,8 +14,10 @@ | |
# %% | ||
import geopandas as gpd | ||
import pygmt | ||
import pyogrio | ||
|
||
# Read shapefile data using geopandas | ||
pyogrio.core._register_drivers() | ||
gdf = gpd.read_file( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Found this issue geopandas/pyogrio#144 that mentions an error like Calling |
||
"http://www2.census.gov/geo/tiger/TIGER2015/PRISECROADS/tl_2015_15_prisecroads.zip" | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move it to
conf.py
so that we don't have to repeat it in multiple gallery examples?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried locally, no it doesn't work if I put it in
doc/conf.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitating to merge this PR because (1) users may be confused about
pyogrio.core._register_drivers()
; (2) Users may still use geopandas v0.x and don't have pyogrio installed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, don't think it's a good option either. I just tried adding it to the Makefile and it doesn't work either.
The funny thing is, the
examples/gallery/maps/choropleth_map.py
example which also has aimport geopandas as gpd
line, and runs before the roads example, doesn't fail with theDataSourceError
. If I move that choropleth_map.py file somewhere else, all the builds work without needing to register the driver manually 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In commit 9883359, I use sphinx-gallery's
sphinx_gallery_start_ignore
/sphinx_gallery_end_ignore
flags to hide the two lines of codes in the documentation.Preview: