Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baseline images for test_grdimage_image #3005

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 16, 2024

Address #2961.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jan 16, 2024
@seisman seisman added this to the 0.11.0 milestone Jan 16, 2024
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_grdimage_image.png

Image diff(s)

Added images

Modified images

Path Old New
test_grdimage_image.png

Report last updated at commit 122d76c

@weiji14 weiji14 mentioned this pull request Jan 16, 2024
14 tasks
@seisman seisman merged commit d0fec93 into main Jan 16, 2024
16 of 18 checks passed
@seisman seisman deleted the test/grdimage-image branch January 16, 2024 04:31
@weiji14
Copy link
Member

weiji14 commented Jan 16, 2024

Somehow test_grdimage_global_subset is still failing on macOS, even though it was updated in #2984

_________________________ test_grdimage_global_subset __________________________
Error: Image files did not match.
  RMS Value: 2.8383277580633415
  Expected:  
    /Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_grdimage.test_grdimage_global_subset/baseline.png
  Actual:    
    /Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_grdimage.test_grdimage_global_subset/result.png
  Difference:
    /Users/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_grdimage.test_grdimage_global_subset/result-failed-diff.png
  Tolerance: 
    2

Maybe just fix it here?

@weiji14
Copy link
Member

weiji14 commented Jan 16, 2024

Oops too late, need to open another PR then 😅

@seisman
Copy link
Member Author

seisman commented Jan 16, 2024

😅 Will open a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants