Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_moon_relief to load Moon relief dataset in various resolutions and registrations #2674

Merged
merged 10 commits into from
Jan 26, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 9, 2023

Description of proposed changes

Preview: https://pygmt-dev--2674.org.readthedocs.build/en/2674/api/generated/pygmt.datasets.load_moon_relief.html

import pygmt
from pygmt.datasets import load_moon_relief
grid = load_moon_relief(resolution="15m")

fig = pygmt.Figure()
fig.grdimage(grid, cmap="@moon_relief.cpt")
fig.show()

moon

Address #2674.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman changed the title load_moon_relief: Load moon relief dataset in various resolutions and registrations WIP: load_moon_relief: Load moon relief dataset in various resolutions and registrations Sep 9, 2023
@seisman seisman added the feature Brand new feature label Sep 13, 2023
@seisman seisman added this to the 0.11.0 milestone Sep 13, 2023
pygmt/datasets/moon_relief.py Outdated Show resolved Hide resolved
pygmt/datasets/moon_relief.py Outdated Show resolved Hide resolved
pygmt/datasets/load_remote_dataset.py Outdated Show resolved Hide resolved
pygmt/datasets/load_remote_dataset.py Outdated Show resolved Hide resolved
yvonnefroehlich added a commit that referenced this pull request Sep 14, 2023
pygmt/datasets/moon_relief.py Outdated Show resolved Hide resolved
pygmt/tests/test_datasets_moon_relief.py Outdated Show resolved Hide resolved
pygmt/tests/test_datasets_moon_relief.py Outdated Show resolved Hide resolved
pygmt/tests/test_datasets_moon_relief.py Outdated Show resolved Hide resolved
pygmt/tests/test_datasets_moon_relief.py Outdated Show resolved Hide resolved
@seisman seisman changed the title WIP: load_moon_relief: Load moon relief dataset in various resolutions and registrations load_moon_relief: Load moon relief dataset in various resolutions and registrations Sep 15, 2023
@seisman seisman changed the title load_moon_relief: Load moon relief dataset in various resolutions and registrations DO NOT MERGE: Add load_moon_relief to load Moon relief dataset in various resolutions and registrations Sep 15, 2023
@seisman seisman marked this pull request as ready for review September 15, 2023 00:21
@seisman seisman added the needs review This PR has higher priority and needs review. label Sep 15, 2023
@seisman seisman removed the needs review This PR has higher priority and needs review. label Oct 28, 2023
@seisman seisman changed the title DO NOT MERGE: Add load_moon_relief to load Moon relief dataset in various resolutions and registrations RFC: DO NOT MERGE: Add load_moon_relief to load Moon relief dataset in various resolutions and registrations Oct 28, 2023
.github/workflows/cache_data.yaml Outdated Show resolved Hide resolved
name="moon relief",
long_name="Moon relief",
units="meters",
extra_attributes={},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that extra_attributes is empty here because I have no idea about the horizontal_datum attribute for the dataset.

@seisman seisman marked this pull request as draft December 21, 2023 09:09
@seisman seisman changed the title RFC: DO NOT MERGE: Add load_moon_relief to load Moon relief dataset in various resolutions and registrations Add load_moon_relief to load Moon relief dataset in various resolutions and registrations Dec 26, 2023
@seisman seisman marked this pull request as ready for review January 14, 2024 08:56
@seisman seisman added the needs review This PR has higher priority and needs review. label Jan 14, 2024
@seisman seisman requested a review from a team January 19, 2024 05:29
pygmt/datasets/load_remote_dataset.py Outdated Show resolved Hide resolved
pygmt/datasets/load_remote_dataset.py Outdated Show resolved Hide resolved
@seisman seisman merged commit f7ad824 into main Jan 26, 2024
19 of 20 checks passed
@seisman seisman deleted the load_moon_relief branch January 26, 2024 13:44
@seisman seisman removed the needs review This PR has higher priority and needs review. label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants