Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make reopt compatible with recent GHCs and dependencies #306

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Ptival
Copy link
Contributor

@Ptival Ptival commented Mar 13, 2024

I've been annoyed by having reopt stuck in the past. This is my attempt at paying the tech debt.

This required a lot of things to happen:

  • Update to changes to LLVM's Config from llvm-pretty,
  • Updates to the added "target triple" in LLVM modules,
  • Changes to LLVM's AST,
  • Dealing more explicitly with the fact that old versions of mtl were exporting for/unless/when from multiple sub-modules e.g. State or Except, whereas recently they no longer do,
  • Dealing with changes in GHC's complain-ness about orphan instances / type operators,
  • Some changes in aeson/attoparsec-aeson,
  • Needed to relax upper bounds to match dependency bounds.

I have tested cabal build all on all 9.2.8, 9.4.8, 9.6.4, 9.8.2.
I have also tried on 8.10.7, it seems to work, though I get linker errors in macaw-base so couldn't fully test.

Pinging @RyanGlScott as a general knowledgeable person, and @staslyakhov to check whether this would impact your work (hopefully not).

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable at a quick glance.

deps/what4 Outdated Show resolved Hide resolved
@Ptival Ptival merged commit 0a74916 into main Mar 14, 2024
2 checks passed
@Ptival Ptival deleted the vr/modernize-reopt branch March 14, 2024 00:28
@Ptival Ptival restored the vr/modernize-reopt branch March 14, 2024 00:29
@Ptival Ptival deleted the vr/modernize-reopt branch April 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants