Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various build fixes #138

Merged
merged 17 commits into from
Apr 18, 2024
Merged

Various build fixes #138

merged 17 commits into from
Apr 18, 2024

Conversation

podhrmic
Copy link
Collaborator

@podhrmic podhrmic commented Feb 9, 2023 •
edited
Loading

  • update generated files
  • fix CI tests
  • fix Makefiles

@podhrmic podhrmic mentioned this pull request Feb 9, 2023
Closed
@podhrmic podhrmic requested a review from kiniry February 10, 2023 02:06
@podhrmic podhrmic changed the title Various build fixes Draft: Various build fixes Feb 15, 2023
@kiniry
Copy link
Member

kiniry commented Feb 15, 2023

I'll pull this and give it a whirl, now that I have my new machine setup.

@podhrmic
Copy link
Collaborator Author

FYI I am rebuilding the docker image right now, it was still having some build problems with cryptol-codegen (hence a DRAFT PR)

@podhrmic
Copy link
Collaborator Author

Yup, looks like I cannot build cryptol-codegen anymore - fails on my Ubuntu host as well as docker. Various versions of Ubuntu and ghc led to the same problem. The repo has no CI , so it is hard to say when the problem was introduced. Looks like some time to polish and fix cryptol-codegen is needed.

@podhrmic podhrmic changed the title Draft: Various build fixes Various build fixes Apr 5, 2024
@podhrmic podhrmic merged commit d4fb4c0 into 135-post-release-polishing Apr 18, 2024
5 checks passed
@podhrmic podhrmic deleted the 135-post-release-polishing-build-fixes branch April 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiniry kiniry Awaiting requested review from kiniry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@podhrmic @kiniry