[4주차] 기본과제 :🌈 예손의 날씨예보 🌈 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dangpy
reviewed
Jun 1, 2023
Comment on lines
+1
to
+3
| import React from "react"; | ||
| import styled from "styled-components"; | ||
| import { useState } from "react"; |
There was a problem hiding this comment.
별건아닌데 요거 import React, {useState} from "react"; 로 한번에 쓰면 더 깔꼼하겠다잉!!
Dangpy
reviewed
Jun 1, 2023
Comment on lines
+27
to
+32
| <St.ComboBox> | ||
| <select onChange={handleSelect}> | ||
| <option value="day">오늘</option> | ||
| <option value="week">주간</option> | ||
| </select> | ||
| </St.ComboBox> |
There was a problem hiding this comment.
요기둥! 바로
<St.ComboBox onChange={handleSelect}>
<option value="day">오늘</option>
<option value="week">주간</option>
</St.ComboBox>ComboBox: styled.select`
& > select {
${({ theme }) => theme.fonts.Content};
color: ${({ theme }) => theme.colors.Blue};
border: 0.2rem solid ${({ theme }) => theme.colors.Blue};
border-radius: 0.5rem;
padding: 0.5rem;
:hover {
background-color: ${({ theme }) => theme.colors.Blue};
color: ${({ theme }) => theme.colors.White};
}
}
`,로 해도 좋을 것 같앙~~~
eastlaw80
reviewed
Jun 2, 2023
Comment on lines
+16
to
+30
| useEffect(() => { | ||
| axios | ||
| .get( | ||
| `https://api.openweathermap.org/data/2.5/weather?q=${area}&appid=${ | ||
| import.meta.env.VITE_APP_WEATHER | ||
| }&units=metric` | ||
| ) | ||
| .then((response) => { | ||
| console.log(response.data); | ||
| setWeather(response.data); | ||
| }) | ||
| .catch((error) => { | ||
| console.log(error); | ||
| }); | ||
| }, [area]); |
There was a problem hiding this comment.
오호 그냥 각각 오늘, 주간 날씨 컴포넌트 안에서 api를 받아왔구나! 명지하고는 또 다르네
| }); | ||
| }, [area]); | ||
|
|
||
| const weatherList = weather.filter((_, index) => (index - 2) % 8 === 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현 기능 명세
✅
기상 카드✅
일간 / 주간 + 지역(영어)검색✅
Outlet + Route✔🌼 PR Point
const imgURL = WEATHER_TYPE.filter( (item) => item.description === weather.weather?.[0].description )[0]?.imgURL || WEATHER_TYPE[0].imgURL;{weatherList.map((item, index) => { const imgURL = WEATHER_TYPE.filter( (type) => type.description === item.weather?.[0].description )[0]?.imgURL || WEATHER_TYPE[0].imgURL;const weatherList = weather.filter((_, index) => (index - 2) % 8 === 0);우선 저는 날씨 데이터가 24시간 기준 3시간마다 업데이트되기 때문에, 결국 하루에 총 8번씩 날씨 정보가 업데이트 되므로, 8로 나누어 떨어지는 인덱스들만 추려냄으로써 총 다섯 개의 날씨 정보만 가져올 수 있도록 했습니닷...
🥺 소요 시간, 어려웠던 점
20h +(?)그리고 주간 옵션에서 40개 날씨 배열을 요일별로 하나씩 총 5개로 자르기까지 생각하는 게 좀 어려웠던 것 같습니다!
다른 분들은 어떻게 해결하셨는지 궁금하네용
🌈 구현 결과물
week4.1.mp4