[7주차 기본 과제] 🌈 카드게임 리팩토링 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamphj3
reviewed
Jun 11, 2023
Comment on lines
+4
to
+27
| interface CardProps { | ||
| imageSrc?: string; | ||
| imageName: string; | ||
| onClick: () => void; | ||
| isOpen: boolean; | ||
| } | ||
|
|
||
| function Card({ imageSrc, onClick, isOpen, imageName }: CardProps) { | ||
| return ( | ||
| <CardWrapper isOpen={isOpen} onClick={onClick}> | ||
| <CardInner isOpen={isOpen}> | ||
| <FrontArticle> | ||
| <Image src={imageSrc} alt={imageName} isOpen={isOpen} /> | ||
| </FrontArticle> | ||
| <BackArticle> | ||
| <Image | ||
| src="https://www.svgrepo.com/show/454281/cat-halloween-kitty.svg" | ||
| alt="default cat" | ||
| /> | ||
| </BackArticle> | ||
| </CardInner> | ||
| </CardWrapper> | ||
| ); | ||
| } |
| cursor: pointer; | ||
| } | ||
| &.open { | ||
| box-shadow: 7px 7px papayawhip; |
| export default Card; | ||
|
|
||
| const CardWrapper = styled.section` | ||
| perspective: 1000px; |
| height: 240px; | ||
| padding: 5px; | ||
| transform: rotateY(180deg); | ||
| backface-visibility: hidden; |
There was a problem hiding this comment.
헐 일케 앞뒷면 보이게 구현한거구나....... 대박 이것도 첨알았어 너무신기해!!!!!3D!!!!!!!!!!
| const CardInner = styled.article` | ||
| position: relative; | ||
| transition: transform 0.6s; | ||
| transform-style: preserve-3d; |
| return ( | ||
| <Section> | ||
| {modes.map((eachMode) => ( | ||
| <Button |
| function Reset({ resetGame }: ResetProps) { | ||
| return ( | ||
| <Section> | ||
| <Button onClick={resetGame}>Reset</Button> |
| import React from "react"; | ||
|
|
||
| interface ResetProps { | ||
| resetGame: () => void; |
There was a problem hiding this comment.
위에는 handle~ 이런식으루 함수 네이밍햇는데 요긴 그냥 resetGame 으로 한 이유가 이써!?
Comment on lines
+36
to
+42
| if (mode === "EASY") { | ||
| setTotalCardCount(5); | ||
| } else if (mode === "NORMAL") { | ||
| setTotalCardCount(7); | ||
| } else if (mode === "HARD") { | ||
| setTotalCardCount(9); | ||
| } |
Comment on lines
+71
to
+78
| const allCatsRandom: string[] = cat | ||
| .sort(() => Math.random() - 0.5) | ||
| .slice(0, totalCardCount) | ||
| .map((eachCat) => eachCat.name); | ||
|
|
||
| setTotalCard( | ||
| [...allCatsRandom, ...allCatsRandom].sort(() => Math.random() - 0.5) | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현 기능 명세
🌼 PR Point
atom 으로 state 관리🌐
recoil 폴더와 atom폴더를 새로 만들어서 atom을 따로 정리해뒀습니다!🗂️
🥺 소요 시간, 어려웠던 점
🌈 구현 결과물