Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gh update dataaccess): Update DataAccess to latest graphhoper version #94

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat(gh update dataaccess): Update DataAccess to latest graphhoper version #94

merged 1 commit into from
Jan 16, 2024

Conversation

rtroilo
Copy link
Member

@rtroilo rtroilo commented Dec 20, 2023 •
edited
Loading

This PR

  • bumps up the java version to 17
  • updates around DataAccess to newer Graphhopper GH5+ version.

Compatibilities

  • with 5.x - master
    • AbstractDataAccess / DataAccess
    • Directory / GHDirectory
    • MMapDataAccess, RAMDataAccess, RAMIntDataAccess
    • StorableProperties

other file are updated to reflect changes in DataAccess but not fully updated to gh 5.x or higher versions.
Most of this changes are cause that DataAccess don't support setSegmentSize anymore! SegmentSize is now passed to the constructor.

Please read our contributing guide and note that also your contribution falls under the Apache License 2.0 as outlined there.

Your first contribution should include a change where you add yourself to the CONTRIBUTORS.md file.

@rtroilo rtroilo marked this pull request as ready for review December 21, 2023 14:28
takb
takb approved these changes Jan 16, 2024
View reviewed changes
Copy link

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@takb takb merged commit 258cc46 into ors_4.0 Jan 16, 2024
2 checks passed
@takb takb deleted the feature/update-gh-dataaccess branch January 16, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takb takb takb approved these changes

@sfendrich sfendrich Awaiting requested review from sfendrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtroilo @takb