Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUK_P tx format added #310

Merged
merged 1 commit into from
Oct 24, 2024
Merged

NUK_P tx format added #310

merged 1 commit into from
Oct 24, 2024

Conversation

PennyHow
Copy link
Member

No description provided.

@PennyHow
Copy link
Member Author

Hi Mads, I think this is all correct for the NUK_P decoding. Please can you take a look and approve if you think it is okay?

@ladsmund
Copy link
Contributor

Hi Mads, I think this is all correct for the NUK_P decoding. Please can you take a look and approve if you think it is okay?

How would you like me to validate the changes?
It can be tested up against a transmitted file from NUK_P. Do you have such file?

As we talked about, the file payload_formats.csv is mainly a configuration file related to our deployed logger programs and it should not be maintained in pypromice in the future. You could consider adding the file to the data repository aws-l0 instead.

@PennyHow
Copy link
Member Author

How would you like me to validate the changes?
It can be tested up against a transmitted file from NUK_P. Do you have such file?

I've been testing from here. I don't have a specific file that I can send you here to test this with. But I can show you here an example:

Transmitted encoded message:

b'sAvS@c\xdb\x00!Cg\x00\x00\x05\nc\x84\x00\x00\x00\x00\x00\x00\x00\x00\x0c\x9e\x7f\xffc\xdaCK\x80\x11\x87\xbf\x00\x00\x00\x00\x7f\xff\x7f\xff\x7f\xff\x7f\xff\x7f\xff2\xf6-\x84\xff\xff\xff\xe4\xff\xff\xff\xfb\x00\x00\x00\x00\x08\x03\x7f\xff\x7f\xff\x7f\xff\x7f?\x7f\xff\x7f\xff6\x94\x04\x886q$\xda\xa4\xf6\x00\xc8Cd\x10hH\xd4'

Decoded L0 data, using the payload formatting in this PR:

2024-10-20 12:00:00,1098273600,987.0,0.033,87.1,0.0,1.29,900.0,0.0,0.0,0.0,0.0,3.23,NAN,986.0,84.3,-0.017,-1.983,0.0,0.0,NAN,NAN,NAN,NAN,NAN,48.54,34.6,-INF,-8164.0,-INF,-8187.0,0.0,0.0,2.051,NAN,NAN,NAN,21348.67967,NAN,57.8,1.16,57.45,12.42,-12.7,0.2,86.8,4.2,226.0`

As we talked about, the file payload_formats.csv is mainly a configuration file related to our deployed logger programs and it should not be maintained in pypromice in the future. You could consider adding the file to the data repository aws-l0 instead.

I could move it now, but then we would also need to re-map the payload format/type files in the docker file. Can we do this quick fix for now, deploy it to our development operations, and then look at moving the files in the near-future?

@PennyHow PennyHow merged commit 671cf92 into develop Oct 24, 2024
3 checks passed
@PennyHow PennyHow deleted the features/tx_nuk_p_addition branch October 24, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants