Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

Fix an obsolete dependency libsystemd-daemon #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dliakh
Copy link

@dliakh dliakh commented Jan 4, 2017

The libsystemd-daemon component referred to from within configure.ac is not available in Ubuntu Trusty which is referenced as a recommended platform for building the project.
The replacement component is libsystemd.
I'm not completely sure that the required minimal version number of 37 is still relevant, the libsystemd version on my Trusty machine reported by pkg-config is 229 which is way higher that the mentioned 37. Build successfully completes after the change. The 'check' make target does not, but that's a different story.

https://at.projects.genivi.org/jira/browse/NSM-1

The libsystemd-daemon component referred to from within configure.ac is not available in Ubuntu Trusty which is referenced as a recommended platform for building the project.
The replacement component is libsystemd.
I'm not completely sure that the required minimal version number of 37 is still relevant, the libsystemd version on my Trusty machine reported by pkg-config is 229 which is way higher that the mentioned 37. Build successfully completes after the change. The 'check' make target does not, but that's a different story.

https://at.projects.genivi.org/jira/browse/NSM-1
@jeremiah
Copy link
Member

@DunderRoffe Would you review this please?

@DunderRoffe
Copy link

I can certainly do a test build and evaluate this pull-request. However, I do not have access to merging it.

@DunderRoffe
Copy link

I can confirm that it builds on the GDP platform (when removing a patch that does the same thing as this pull-request from meta-ivi).

The patch itself looks good. However, I would recommend conforming to the commit message rules defined at the GENIVI wiki: https://at.projects.genivi.org/wiki/display/PROJ/Rules+for+Commit+Messages

@jeremiah
Copy link
Member

@dliakh Can you respond to the request to follow the commit message rules in your PR? Once that is done I will ping the NSM maintainer to see if they cannot commit this patch.

Thanks!

@dliakh
Copy link
Author

dliakh commented Feb 16, 2017 via email

@jeremiah jeremiah requested review from ihuerner and guysagnes and removed request for ihuerner and guysagnes March 1, 2017 23:34
@jp-bogler
Copy link

I would like to stay backwards compatible and suggest to do the package check like this:

PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon libsystemd-login],,
[PKG_CHECK_MODULES([SYSTEMD], [libsystemd])])

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants