Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Ciric PolyhedralPrism #2769

Draft
wants to merge 54 commits into
base: develop
Choose a base branch
from
Draft

WIP: Ciric PolyhedralPrism #2769

wants to merge 54 commits into from

Conversation

CoronelBuendia
Copy link
Contributor

@CoronelBuendia CoronelBuendia commented Oct 30, 2023 •
edited
Loading

Linked Issues

Closes #{ID}

UPDATE: Put on hold, because we have been unable to get a working implementation. This is still desirable (it is a more general form of an arbitrary current source).

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@CoronelBuendia
baseclasses and housekeeping
79551b7
@CoronelBuendia
pause because PROCESS
98340e5
@CoronelBuendia
6 hours
f744e4c
@CoronelBuendia
write asserts
6e69808
@CoronelBuendia
vector potential
1f8647e
@CoronelBuendia
add failing babic test
02cbd6e
@CoronelBuendia
add singularity protection
3755b3b
@CoronelBuendia
add singularity protection
d0c0d12
@CoronelBuendia
typing
2b01e15
@CoronelBuendia
add plotting to Babic Aykel test
412deee
@CoronelBuendia
baseclass shenanigans
c0d1316
@CoronelBuendia
DRY mixin
6f9af62
@CoronelBuendia
working arbirtrary geometry
4085d98
@CoronelBuendia
clean up
1822048
@CoronelBuendia
clean up
b96b066
@CoronelBuendia
kill some list reflection but still not fully JIT
837c269
@CoronelBuendia
fix signatures
0b34d3b
@CoronelBuendia
add triangle test
8385ac7
@CoronelBuendia
rotate midpoints too
d60b6e0
@CoronelBuendia
comments and clearer code
d4dce2c
@CoronelBuendia
add some docstring equations
7ea9e35
@CoronelBuendia
more docstring equations
5a210e7
@CoronelBuendia
parametrise babic aykel test
7a71544
@CoronelBuendia
more source doucmentation
141606b
@CoronelBuendia
parametrise maths test
e3cd1ca
@CoronelBuendia
remove useless baseclass and make everything private
707f97e
@CoronelBuendia
make more stuff private
3343c2c
@CoronelBuendia
make stuff private everywhere
2c1b425
@CoronelBuendia
better file docstring
3468bc4
@CoronelBuendia
biot savart private points
78d3eb5
@CoronelBuendia
Add an alternative polyhedral VIM formulation (#2731)
0bb07f3 
* working bottura

* get rid of some minuses

* kernel start

* docstrings

* ruff

* make tests better written

* more maths

* fix API documentation
@CoronelBuendia
Add ArbitraryPlanarPolyhedralXSCircuit (#2704)
ae32e6b 
* add baseclass

* arbitrary planar polyhedral

* arbitrary planar polyhedral proper

* add tests

* addplot test

* DRY

* remove unused zip

* rebase and fix circuit tests
@CoronelBuendia
add kernel name to test plot
d173565
@CoronelBuendia
add kernel name to test plot
02f1c7a
@CoronelBuendia
first pass up to lambda
2f3443b
@CoronelBuendia
jesus christ ciric
2301753
@CoronelBuendia
jesus christ ciric
da766e6
@CoronelBuendia
local coordiantes wrong
84555af
@CoronelBuendia
local coordiantes wrong
e22111f
@CoronelBuendia
some progress with normal arctan
3e2e780
@CoronelBuendia
light
68a9043
@CoronelBuendia
TODOs and cleanup
07fb190
@CoronelBuendia
TODOs and cleanup and mess up
b922764
@CoronelBuendia CoronelBuendia added the magnetostatics Tasks relating to the magnetostatics module label Oct 30, 2023
@CoronelBuendia CoronelBuendia requested a review from a team as a code owner October 30, 2023 10:59
@CoronelBuendia CoronelBuendia changed the base branch from develop to matti/polyhedral-prism-fabri October 30, 2023 11:00
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@CoronelBuendia CoronelBuendia added the on hold Tasks that are paused label Dec 12, 2023
Base automatically changed from matti/polyhedral-prism-fabri to develop January 24, 2024 12:01
@je-cook je-cook marked this pull request as draft March 15, 2024 08:14
@je-cook je-cook force-pushed the develop branch 5 times, most recently from 5a50acb to 7574352 Compare May 15, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
magnetostatics Tasks relating to the magnetostatics module on hold Tasks that are paused
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CoronelBuendia @kj5248