Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Forc.toml #261

Closed
wants to merge 5 commits into from
Closed

Update Forc.toml #261

wants to merge 5 commits into from

Conversation

Budalebah
Copy link

@Budalebah Budalebah commented Jul 3, 2024

v0.5.1

Type of change

  • Bug fix
  • New feature
  • Improvement (refactoring, restructuring repository, cleaning tech debt, ...)
  • Documentation
  • Other (describe below)

Changes

The following changes have been made:

  • Change 1
  • Change 2

Notes

  • Note 1

Related Issues

Closes #<issue number>

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.
  • I have updated the changelog to reflect the changes on this PR.

@Budalebah Budalebah requested a review from a team as a code owner July 3, 2024 10:05
@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

@Budalebah
Copy link
Author

Sorry i dont understand @bitzoic

@K1-R1
Copy link
Member

K1-R1 commented Jul 16, 2024

Hi @Budalebah, we encourage all contributions but we will not be able to merge this PR in it's current form as updating the Forc.toml manifest must be accompanied by re-building the libs so that the Forc.lock file is also updated. Typically we update dependencies when we need to as opposed to whenever the latest version arrives, however I will leave it to you to decide if you want to close this PR or rebuild the libs

@Budalebah
Copy link
Author

I will do it

@bitzoic
Copy link
Member

bitzoic commented Aug 12, 2024

Closed in #281

@bitzoic bitzoic closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants