Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Sway-Libs to Forc v0.47.0 and Sway-Standards v0.2.0 #202

Merged
merged 11 commits into from
Nov 13, 2023
Merged

Bump Sway-Libs to Forc v0.47.0 and Sway-Standards v0.2.0 #202

merged 11 commits into from
Nov 13, 2023

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Nov 10, 2023

Type of change

  • Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes

The following changes have been made:

  • Updates the repo to forc v0.47.0
  • Updates the repo to Sway-Standards v0.2.0
  • Updates the repo to fuel-core v0.20.8

@bitzoic bitzoic self-assigned this Nov 10, 2023
@bitzoic bitzoic requested a review from a team as a code owner November 10, 2023 10:10
@bitzoic bitzoic added Improvement Enhancing a feature that already exists Repo Misc General repository upkeep labels Nov 10, 2023
Braqzen
Braqzen previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Braqzen Braqzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting intensifies!

GL on those CI errors, ouch

@bitzoic bitzoic requested review from a team and Braqzen November 13, 2023 11:08
SwayStar123
SwayStar123 reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@SwayStar123 SwayStar123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from this type, gonna need to change the places where this variable is used aswell

libs/fixed_point/src/ifp128.sw Outdated Show resolved Hide resolved
@bitzoic bitzoic requested review from SwayStar123 and a team November 13, 2023 11:15
@bitzoic bitzoic enabled auto-merge (squash) November 13, 2023 11:15
@bitzoic bitzoic merged commit a585660 into master Nov 13, 2023
4 checks passed
@bitzoic bitzoic deleted the bitzoic-bump-v0.47 branch November 13, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwayStar123 SwayStar123 SwayStar123 approved these changes

@Braqzen Braqzen Awaiting requested review from Braqzen

Assignees

@bitzoic bitzoic

Labels
Improvement Enhancing a feature that already exists Repo Misc General repository upkeep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitzoic @SwayStar123 @Braqzen