Update utils.mjs #1605
Open
Update utils.mjs #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes and Explanation: Removed Redundant ./ in Path Concatenation: In join(APP_PATH, './fuel-wallet.zip'), the ./ is unnecessary when using join. Replaced with join(APP_PATH, 'fuel-wallet.zip') to simplify the path concatenation. Added Conditional Check for Setting Environment Variables: Instead of assigning values directly in setEnvVar, I added a conditional check if (!process.env[key]). This ensures the environment variable is only set if it is not already defined, which avoids unnecessary overwriting. Consolidated console.log Outputs: Instead of calling console.log multiple times, I grouped all logs together into one output. This reduces redundancy and makes it easier to follow what is being logged, improving readability and reducing noise in the console. Replaced Deprecated stdout: 'inherit' with stdio: 'inherit': In the execa call, the correct option for forwarding output to the parent process is stdio: 'inherit' instead of stdout: 'inherit'. This ensures that the command’s output is properly displayed. Avoided Unnecessary Recursive Path ./dist: Removed the ./ from join(ROOT_PATH, './dist') since it's redundant. join(ROOT_PATH, 'dist') is sufficient. These changes improve code clarity, maintainability, and performance by reducing redundancy and ensuring proper handling of environment variables and logs.
voronor
requested review from
luizstacio,
pedronauck,
LuizAsFight,
helciofranco,
arthurgeron,
rodrigobranas and
nelitow
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes and Explanation:
Removed Redundant ./ in Path Concatenation:
In join(APP_PATH, './fuel-wallet.zip'), the ./ is unnecessary when using join. Replaced with join(APP_PATH, 'fuel-wallet.zip') to simplify the path concatenation.
Added Conditional Check for Setting Environment Variables:
Instead of assigning values directly in setEnvVar, I added a conditional check if (!process.env[key]). This ensures the environment variable is only set if it is not already defined, which avoids unnecessary overwriting.
Consolidated console.log Outputs:
Instead of calling console.log multiple times, I grouped all logs together into one output. This reduces redundancy and makes it easier to follow what is being logged, improving readability and reducing noise in the console.
Replaced Deprecated stdout: 'inherit' with stdio: 'inherit':
In the execa call, the correct option for forwarding output to the parent process is stdio: 'inherit' instead of stdout: 'inherit'. This ensures that the command’s output is properly displayed.
Avoided Unnecessary Recursive Path ./dist:
Removed the ./ from join(ROOT_PATH, './dist') since it's redundant. join(ROOT_PATH, 'dist') is sufficient.
These changes improve code clarity, maintainability, and performance by reducing redundancy and ensuring proper handling of environment variables and logs.