[TASK] Remove unused feature "Elements on page" (#690)

Resolves: #689
FriendsOfTYPO3 · Aug 4, 2023 · 7c248c8 · 7c248c8
1 parent c56ff78
commit 7c248c8
Show file tree

Hide file tree

Showing 9 changed files with 2 additions and 136 deletions.
diff --git a/Classes/Hook/FrontendEditingInitializationHook.php b/Classes/Hook/FrontendEditingInitializationHook.php
@@ -297,7 +297,6 @@ public function main(array $params, TypoScriptFrontendController $parentObject)
             'currentTime' => GeneralUtility::makeInstance(Context::class)->getPropertyFromAspect('date', 'timestamp'),
             'currentPage' => $this->typoScriptFrontendController->id,
             'contentItems' => $availableContentElementTypes,
-            'contentElementsOnPage' => $this->getContentElementsOnPage((int)$this->typoScriptFrontendController->id),
             'customRecords' => $this->getCustomRecords(),
             'loadingIcon' => $this->iconFactory->getIcon('spinner-circle-dark', Icon::SIZE_LARGE)->render(),
             'showHiddenItemsUrl' => $requestUrl . '&show_hidden_items=' . $this->showHiddenItems(),
@@ -472,30 +471,6 @@ protected function wizardItemsHook(array &$wizardItems, Typo3NewContentElementCo
         }
     }
 
-    /**
-     * Get the content elements on the page
-     *
-     * @param int $pageId The page id to fetch content elements from
-     * @return array
-     */
-    protected function getContentElementsOnPage(int $pageId): array
-    {
-        if (!$this->typoScriptFrontendController->cObj instanceof ContentObjectRenderer) {
-            $this->typoScriptFrontendController->newCObj();
-        }
-        $contentElements = $this->typoScriptFrontendController->cObj->getRecords(
-            'tt_content',
-            [
-                'pidInList' => $pageId,
-                'orderBy' => 'sorting'
-            ]
-        );
-        foreach ($contentElements as &$contentElement) {
-            $contentElement['_recordTitle'] = BackendUtility::getRecordTitle('tt_content', $contentElement);
-        }
-        return $contentElements;
-    }
-
     /**
      * Get custom records defined in TypoScript
      *

diff --git a/Resources/Private/Language/locallang.xlf b/Resources/Private/Language/locallang.xlf
@@ -90,12 +90,6 @@
             <trans-unit id="right-bar.element-title">
                 <source>Drag and drop on page to create a new '%s' content element.</source>
             </trans-unit>
-            <trans-unit id="right-bar.on-page.changed">
-                <source>Modified:</source>
-            </trans-unit>
-            <trans-unit id="right-bar.on-page.title">
-                <source>Elements on page</source>
-            </trans-unit>
             <trans-unit id="right-bar.custom-record.title">
                 <source>Custom records</source>
             </trans-unit>

diff --git a/Resources/Private/Partials/ContentElementHierarchyTab.html b/Resources/Private/Partials/ContentElementHierarchyTab.html
diff --git a/Resources/Private/Partials/RightBar.html b/Resources/Private/Partials/RightBar.html
@@ -6,9 +6,6 @@
 			<div class="elements">
 				<f:render partial="WizardElementTabs" arguments="{_all}"></f:render>
 			</div>
-			<div class="elements">
-				<f:render partial="ContentElementHierarchyTab" arguments="{_all}"></f:render>
-			</div>
 			<f:if condition="{customRecords}">
 				<div class="elements">
 					<f:render partial="CustomRecordTab" arguments="{_all}"></f:render>

diff --git a/Resources/Private/Sass/Partials/_elements.scss b/Resources/Private/Sass/Partials/_elements.scss
@@ -71,7 +71,6 @@
     }
 }
 
-.content-element-hierarchy-tab,
 .custom-record-tab {
     .accordion {
         .element-action {

diff --git a/Resources/Private/Sass/inline_editing.scss b/Resources/Private/Sass/inline_editing.scss
@@ -81,17 +81,6 @@
         display: inline;
     }
 
-    // colored frame when hovering content element in right-column list
-
-    &.indicate-element {
-        &:before,
-        &:after {
-            content: none !important;
-        }
-
-        outline: 1px solid $color-t3-primary;
-    }
-
     &[draggable="true"]:hover {
         cursor: pointer;
     }

diff --git a/Resources/Public/Css/frontend_editing.css b/Resources/Public/Css/frontend_editing.css
diff --git a/Resources/Public/Css/inline_editing.css b/Resources/Public/Css/inline_editing.css
diff --git a/Resources/Public/JavaScript/FrontendEditing.js b/Resources/Public/JavaScript/FrontendEditing.js
@@ -73,9 +73,6 @@ define([
         this.init();
     };
 
-    // TimeoutId used in indicateCeStart()
-    var indicateCeScrollTimeoutId = null;
-
     // Add default events and a function to add other events
     FrontendEditing.events = events;
     FrontendEditing.addEvent = function addEvent (key, value) {
@@ -563,50 +560,6 @@ define([
             }
         },
 
-        indicateCeStart: function (ev) {
-            log.debug('start indicate ce', ev.currentTarget);
-
-            var $iframe = F.iframe();
-            var uid = ev.currentTarget.dataset.uid;
-            $iframe.contents()
-                .find('#c' + uid)
-                .parent()
-                .addClass('indicate-element');
-            window.clearTimeout(indicateCeScrollTimeoutId);
-
-            indicateCeScrollTimeoutId = window.setTimeout(function scrollCe () {
-                log.info('scroll to Ce', uid);
-
-                var $iframe = F.iframe();
-                var offset = $iframe.contents()
-                    .find('#c' + uid)
-                    .parent()
-                    .offset();
-
-                $iframe.contents()
-                    .find('body, html')
-                    .animate({
-                        scrollTop: offset
-                            ? offset.top - scrollToIndicateCeOffsetTop
-                            : offset
-                    }, scrollToIndicateCeSpeed);
-            }, scrollToIndicateCeDelay);
-        },
-
-        indicateCeEnd: function (ev) {
-            log.debug('end indicate ce', ev.currentTarget);
-
-            var $iframe = F.iframe();
-            var uid = ev.currentTarget.dataset.uid;
-
-            $iframe.contents()
-                .find('#c' + uid)
-                .parent()
-                .removeClass('indicate-element');
-
-            window.clearTimeout(indicateCeScrollTimeoutId);
-        },
-
         dropCr: function (ev) {
             log.debug('drop cr', ev.currentTarget, ev.dataTransfer);