Uncrustify PR Check Update #969
Conversation
| exit 0 | ||
| else | ||
| echo -e "\033[31;1;43mFormatting check (using Uncrustify) failed...\033[0m" | ||
| echo -e "\033[32;3mTo have the code uncrustified for you, please comment '/bot run uncrustify' (without the quotes) on the Pull Request.\033[0m" |
There was a problem hiding this comment.
I would still like for this to be printed out in case of failure. This repo has a workflow which uncurstifies the code when you comment that.
There was a problem hiding this comment.
That bot would need to be updated to use the new version of uncrustify. I also dislike that this is the only repo out of all of ours that offers that as an option. I'm going to talk to @A-Zaba about getting this added into the repo and maybe tying it into this one.
There was a problem hiding this comment.
That bot would need to be updated to use the new version of uncrustify
Yes.
I also dislike that this is the only repo out of all of ours that offers that as an option
Yes, we should add it to the CI-CD repo and have it in all of our repos.
| else | ||
| exit 0 | ||
| fi | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
This is probably a nit pick but maybe we want to use actions/checkout@v3? It uses a more up-to-date version of Node.
There was a problem hiding this comment.
Fully agree with you, but all of our repos are using the checkout@v2 where I would prefer to do that change across all of them at once compared to individual repos.
|
/bot run uncrustify |
1 similar comment
|
/bot run uncrustify |
|
/bot run uncrustify |
|
/bot run uncrustify |
|
/bot run uncrustify |
Uncrustify PR Check Update
Description
Change to uncrustify to show files that need to be updated and create a cleaner log on runs
Test Steps
Ran the workflow after the changes to ensure it worked, failed run one, failed run two, and a passing run
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.