Fix ARP failure with loopback addresses #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htibosch
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Thank you @tony-josi-aws for creating this PR and repairing the unit-tests.
The loopback users will be happy.
kar-rahul-aws
approved these changes
Sep 12, 2024
aggarg
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
eARPGetCacheEntryto handle loopback addresses correctly and assign the loopback endpoint's MAC address as the lookup MAC address.Update the loopback interface to refresh the ARP/ND caches correctly and drop packets that cannot find a matching endpoint that can handle the packet.
We thank @htibosch for this fix.
Also thanks to @rickou and @grap for reporting this issue in #1179 and in the FreeRTOS forum.
Test Steps
Loopback test on TCP socket with STM32H7 NUCLEO.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.