Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -test results to the panel #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yzgyyang
Copy link
Member

Add results for -test builds when available.

When I was there:

  • Added global variables for local and staging env
  • Added a JSON example with a server for local dev

@yzgyyang
Copy link
Member Author

Preview at https://people.freebsd.org/~ygy/tinderbox/.

@lwhsu
Copy link
Contributor

lwhsu commented Nov 30, 2020

The result looks good to me, maybe we can arrange the information as following:

Revision: rXXXX
Build: <date> <details>
Test: <date> <results>

And use text color on field to mark the result is successful, unstable or failed.

One thing I overlooked when talking about the idea, currently I guess the shown test result is from the last or last completed test build, but those two builds might not have directly relationship, i.e., they are not against the same revision.

The "started by" information can be retrieved from the item with hudson.model.CauseAction class in actions array in the build information.
See https://ci.freebsd.org/job/FreeBSD-head-amd64-test/17320/api/json?pretty=true for example, it should also be retrieved from https://ci.freebsd.org/api/json by providing right parameters.

This might increase much complexity of the implementation, if it is too difficult, let's find a better way to organize and display those data.

@lwhsu
Copy link
Contributor

lwhsu commented Nov 30, 2020

example.json looks like sample data, does it need to be included in the final commit?
Also what's the reason of renaming server.js to server-proxy.js?

While I was there, also:
- Made the table header sticky (on modern browsers)
- Only show last successful build for jobs with FAILURE
@yzgyyang
Copy link
Member Author

yzgyyang commented Dec 4, 2020

One thing I overlooked when talking about the idea, currently I guess the shown test result is from the last or last completed test build, but those two builds might not have a direct relationship, i.e., they are not against the same revision.

@lwhsu That makes sense. I have implemented a side-by-side view for build and test, as well as adding a sticky header for the table. The end result looks like this: (https://people.freebsd.org/~ygy/tinderbox/)

image

Please let me know how I can improve the display to be clearer with sufficient info.

Also what's the reason of renaming server.js to server-proxy.js?
example.json looks like sample data, does it need to be included in the final commit?

proxy-server.js is for forwarding the result without the CORS restriction, and since I don't have a stable connection, I made a helper json-server.js that serves an example.json directly on localhost. IMO these two server scripts are just for development, so I could possibly move them to a dev folder to avoid confusion? (or is the server actually using the server.js?)

@yzgyyang yzgyyang requested review from lwhsu and emaste and removed request for lwhsu and emaste December 7, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants