Enable more agressive scrobble checking behavior #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoxxMD
added
enhancement
* Move recentScrobbles and generic refresh logic into abstract class * New abstract function for scrobbler children to implement to get scrobbler-specific play lists on refresh * Implement shouldRefereshScrobble with logging for better insight into why or why not a scrobbler refreshed upstream scrobbles
…ess time Use refreshStaleAfter to force refresh to user can configure the time. Allows more nuanced refreshing behavior as well as always refresh (0 seconds)
|
Added additional mechanisms to trigger an upstream scrobble refresh:
Added debug logging insight into refresh triggers -- when a client is about to scrobble it will see if it should refresh, if it needs to refresh it will log the reason why it is logging to DEBUG level. |
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to potentially address duplicate scrobble issues when client<-->source feedback loops occur #173
Force Scrobble RefreshUpdate scrobble config options to enable refreshing upstream service existing scrobbles in MS on every scrobble so that MS guarantees it always has the latest existing scrobbles to check for dups.Refresh Stale At
Force client to refresh scrobbled plays from upstream service if last refresh was at least X seconds ago
listenbrainz.jsonor another scrobble config[ { "name": "myScrobbler", "data": { // ... }, + "options": { + "refreshStaleAfter": 5 + } } ]