Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct argument type, fixes #1508 #1672

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Correct argument type, fixes #1508 #1672

wants to merge 1 commit into from

Conversation

foobar13372
Copy link

No description provided.

@foobar13372
Copy link
Author

Is anyone still working on this extension?

#1508 (comment) says a pull request speeds up fixing this absolutely trivial task. Now it's here and gets still ignored.

If ext:vhs is abandoned please make an official announcement to save everyones time....

@NamelessCoder
Copy link
Member

Is anyone still working on this extension?

Yes.

#1508 (comment) says a pull request speeds up fixing this absolutely trivial task.

While it might look trivial to you, it changes public API and therefore may need to wait for a new major version to be close to release. My initial comment to you also informed you that it is a semi-low priority issue.

Now it's here and gets still ignored.

Pending for 12 days does not mean "ignored". There's a space of 11 months between my initial comment to you and this PR being created (which means the change wasn't included in the last major version, 6.0) so I can only assume it isn't extremely high priority for you either.

If ext:vhs is abandoned please make an official announcement to save everyones time....

My advise: be more patient when contributing to open source. Don't write passive-aggressive messages and remember that while this may be ultra important from your point of view, it may not be so from the majority of users' points of view.

That said: please change the type to iterable as initially recommended. This will make the PR ready for merging but as mentioned, it may not be merged and included in a release until the next major version is coming up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants