Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix horizontal recyclerlistview in android RTL #753

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OsaedYahya
Copy link

This contains a fix for Horizontal recyclerlistview while using RTL in android devices/emulators
this was tested for each rendered item to be sequentially loaded unlike current behavior

@@ -241,22 +244,26 @@ export default class ViewabilityTracker {
newEngagedIndexes: number[]): boolean {
const itemRect = this._layouts[index];
let isFound = false;
const newIndex =
I18nManager.isRTL && Platform.OS === "android"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
I18nManager.isRTL && Platform.OS === "android"
I18nManager.isRTL && Platform.OS === "android" && this._isHorizontal

To not mess up the vertical lists we need to make sure this check only applies to horizontal scrollview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants