Base POCO parsers/serializers on POCO, not IROD #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0/parse-elements-for-xml-parsers
# Conflicts: # src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
# Conflicts: # src/Hl7.Fhir.Base/CompatibilitySuppressions.xml # src/Hl7.Fhir.Base/Serialization/BaseFhirJsonPocoSerializer.cs # src/Hl7.Fhir.Base/Serialization/FhirJsonConverter.cs
ewoutkramer
commented
Oct 23, 2024
Kasdejong
reviewed
Oct 24, 2024
| @@ -84,8 +88,11 @@ public static async Task<string> ToXmlAsync(this ITypedElement source, FhirXmlSe | |||
| return await SerializationUtil.WriteXmlToStringAsync(async writer => await source.WriteToAsync(writer, settings).ConfigureAwait(false), settings?.Pretty ?? false, | |||
| settings?.AppendNewLine ?? false).ConfigureAwait(false); | |||
|
|
|||
| var engine = FhirSerializationEngineFactory.Strict(ModelInspector.ForType(b.GetType())); | |||
| return ((PocoSerializationEngine)engine).SerializeToXml(b); | |||
| // Note that this code is temporary, as we the above code will be re-instated here. It's therefore | |||
There was a problem hiding this comment.
if it is temporary, maybe we should mark it with [TemporarilyChanged]?
| return SerializationUtil.WriteXmlToString(source, (s,w) => s.WriteTo(w, settings), | ||
| settings?.Pretty ?? false, settings?.AppendNewLine ?? false); | ||
|
|
||
| // Note that this code is temporary, as we the above code will be re-instated here. It's therefore |
There was a problem hiding this comment.
if it is temporary, maybe we should mark it with [TemporarilyChanged]?
Kasdejong
requested changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeserializeReaderToJsonhas becomeDeserializeFromJsonReader).Fixes #2917.