-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Poco serializers to work against Base #2917
Comments
I am not sure this is beneficial. It allows us to cover the minor usecase of using the parents element name when serializing subtrees of resources (which officially does not exist) but otherwise, serialization does not need a parent, and so the current itypedelement based direct implementation on pocos would introduce overhead to serialization (including calculation Value) for little profit. If we want to move away from using IROD we should probably just write the serializers against POCO directly, it internally assumes it is using pocos anyway. |
Another note: to make it possible to maintain correct XML ordering, we need to make sure the XML poco parser annotates the nodes with the order, so it can be maintained. We can also add an |
We should also extend IFhirSerializationEngine to allow for "Base" (de)serializing |
⚠ I have changed the PocoXml/Json serializers to work against Base, not IReadOnlyDictionary<> ⚠ I have removed the following methods that were already obsolete:
|
Change the serializers to use the new IScopedNode interface.
The text was updated successfully, but these errors were encountered: