Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS sdk version. #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add iOS sdk version. #7

wants to merge 1 commit into from

Conversation

TusharFA
Copy link
Collaborator

@TusharFA TusharFA commented Jul 6, 2021

Description

https://app.asana.com/0/1200120967863460/1200419991699246/f
Signed-off-by: Tushar Sharma [email protected]

Add iOS sdk version instead of 0.
Please note this change has not been tested due to unavailability of an iOS test device or mac.
Please test it before merging it into main.

Links :

No Links.

Commits

  • [Add] Add iOS sdk version.

Tests

No Test(s) added.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read and followed the Best Practices Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • Added relevant reviewers.

Breaking Change

  • No, no existing tests failed.
  • Yes, this is a breaking change.

Should be merge type:

  • Squash and merge
  • Rebase and merge

@TusharFA TusharFA requested a review from someshubham July 6, 2021 07:05
Copy link
Member

@apgapg apgapg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants