Make wireclient.Conn.Login more robust
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 65.75% 65.33% -0.43%
==========================================
Files 41 41
Lines 1799 1829 +30
==========================================
+ Hits 1183 1195 +12
- Misses 446 458 +12
- Partials 170 176 +6
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
commented
Oct 3, 2024
AlekSi
reviewed
Oct 8, 2024
wireclient/wireclient.go
Outdated
Comment on lines
342
to
345
| // when `saslContinue` is called twice the SCRAM client conversation is | ||
| // completed before the second `saslContinue` request, | ||
| // ensure to move only the incomplete conversation forward | ||
| if !conv.Done() { |
There was a problem hiding this comment.
That was a bit that bothered me for so long. Is is kinda like "are we done yet? if not, try again" logic. But with authentication it should be stricter that that
AlekSi
reviewed
Oct 8, 2024
AlekSi
changed the title
wireclient login handle incomplete conversationwireclient.Conn.Login more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.