-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make wireclient.Conn.Login
more robust
#52
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 65.75% 65.33% -0.43%
==========================================
Files 41 41
Lines 1799 1829 +30
==========================================
+ Hits 1183 1195 +12
- Misses 446 458 +12
- Partials 170 176 +6
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
wireclient/wireclient.go
Outdated
// when `saslContinue` is called twice the SCRAM client conversation is | ||
// completed before the second `saslContinue` request, | ||
// ensure to move only the incomplete conversation forward | ||
if !conv.Done() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a bit that bothered me for so long. Is is kinda like "are we done yet? if not, try again" logic. But with authentication it should be stricter that that
wireclient
login handle incomplete conversationwireclient.Conn.Login
more robust
No description provided.