-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kotlin version; remove support for 1.7 #803
Conversation
@@ -17,7 +17,9 @@ jobs: | |||
matrix: | |||
java_version: ['8', '17', '21'] | |||
# Versions need to align with ones in 'main.yml' workflow | |||
kotlin_version: ['1.7.22', '1.8.10', '1.9.23', '2.0.0-Beta4'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue/PR to link to, wrt dropping support for Kotlin 1.7?
I'll make a minor note on https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.18 but could use a link from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically, this PR is for changing the default Kotlin version; I can link to this one but if so should explain the reason for dropping in description, if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because Kotlin 2.0
has been released.
The description has also been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok but neither title nor description mentions dropping 1.7 -- I can modify title.
The point is to make it visible to everybody who happens to see this PR, or link to it.
To give bit of context.
Thanks!
kotlin_version: ['1.7.22', '1.8.10', '1.9.23', '2.0.0-Beta4'] | ||
# kotlin-reflect 1.8.2x has a bug and some tests fail, so we are downgrading to 1.8.10. | ||
# https://youtrack.jetbrains.com/issue/KT-65156 | ||
kotlin_version: ['1.8.10', '1.9.23', '2.0.0-Beta4'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably 2.0.0-Beta4 could become 2.0.0
(or 2.0.0-Final
or whatever it is?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been corrected by another PR.
https://github.com/FasterXML/jackson-module-kotlin/tree/2.18/.github/workflows
Dropping 1.7 support because
Kotlin 2.0
has been released.https://github.com/JetBrains/kotlin/releases/tag/v2.0.0