add support for Map argument

[gkorland]

fix #68

Summary by CodeRabbit

• New Features

  • Enhanced the string conversion functionality to support Map objects, allowing for improved representation of complex data structures.

• Tests

  • Added a new test for verifying the creation of graph nodes using map structures, enhancing test coverage for node creation operations.

[coderabbitai]

Walkthrough

The changes made in this pull request enhance the valueToString method in the Utils class to support the conversion of Map objects to string representations. Previously, the method only handled List and other types, but now it can also process Map instances by iterating over their entries and recursively converting keys and values to strings. This modification improves the method's versatility in handling complex data structures.

Changes

Files	Change Summary
src/main/java/com/falkordb/impl/Utils.java	Enhanced valueToString method to include support for converting Map objects to string format.
src/test/java/com/falkordb/GraphAPITest.java	Added testMapSupport method to validate map handling in node creation tests.

Assessment against linked issues

Objective	Addressed	Explanation
Add support for Map in prepareQuery (#68)	✅

🐰 In the land of code where rabbits play,
A map now sings in a string ballet.
With keys and values dancing in line,
Our valueToString shines, oh so fine!
Hops of joy for each data type,
In curly braces, they now delight! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 78922bc and 507e3d9.

Files selected for processing (1)

• src/test/java/com/falkordb/GraphAPITest.java (1 hunks)

Additional comments not posted (1)

src/test/java/com/falkordb/GraphAPITest.java (1)

698-717: LGTM!

The testMapSupport method provides a good test case for creating nodes with properties using a map argument. It correctly parameterizes the query and makes appropriate assertions to verify the node was created as expected.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.52%. Comparing base (b3efd1d) to head (78922bc).

Files with missing lines	Patch %	Lines
src/main/java/com/falkordb/impl/Utils.java	0.00%	9 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
- Coverage     72.54%   71.52%   -1.02%     
  Complexity      217      217              
============================================
  Files            25       25              
  Lines           703      713      +10     
  Branches         64       67       +3     
============================================
  Hits            510      510              
- Misses          157      166       +9     
- Partials         36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

src/main/java/com/falkordb/impl/Utils.java (1)

88-101: Add tests to improve code coverage.

The static analysis tool has flagged that the added lines are not covered by tests. To ensure the reliability and maintainability of the code, it's important to have adequate test coverage.

Do you want me to generate test cases for the added functionality or open a GitHub issue to track this task?

Tools

GitHub Check: codecov/patch

[warning] 90-91: src/main/java/com/falkordb/impl/Utils.java#L90-L91
Added lines #L90 - L91 were not covered by tests

---

[warning] 93-94: src/main/java/com/falkordb/impl/Utils.java#L93-L94
Added lines #L93 - L94 were not covered by tests

---

[warning] 97-97: src/main/java/com/falkordb/impl/Utils.java#L97
Added line #L97 was not covered by tests

---

[warning] 99-100: src/main/java/com/falkordb/impl/Utils.java#L99-L100
Added lines #L99 - L100 were not covered by tests

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b3efd1d and 78922bc.

Files selected for processing (1)

• src/main/java/com/falkordb/impl/Utils.java (1 hunks)

Additional context used

GitHub Check: codecov/patch

src/main/java/com/falkordb/impl/Utils.java

[warning] 90-91: src/main/java/com/falkordb/impl/Utils.java#L90-L91
Added lines #L90 - L91 were not covered by tests

---

[warning] 93-94: src/main/java/com/falkordb/impl/Utils.java#L93-L94
Added lines #L93 - L94 were not covered by tests

---

[warning] 97-97: src/main/java/com/falkordb/impl/Utils.java#L97
Added line #L97 was not covered by tests

---

[warning] 99-100: src/main/java/com/falkordb/impl/Utils.java#L99-L100
Added lines #L99 - L100 were not covered by tests

Additional comments not posted (1)

src/main/java/com/falkordb/impl/Utils.java (1)

88-101: LGTM! The code changes align with the PR objectives.

The added support for converting Map objects to string representations in the valueToString method addresses the limitation mentioned in the linked issue #68. The implementation correctly handles the recursive conversion of map entries and formats the resulting string appropriately.

Tools

GitHub Check: codecov/patch

[warning] 90-91: src/main/java/com/falkordb/impl/Utils.java#L90-L91
Added lines #L90 - L91 were not covered by tests

---

[warning] 93-94: src/main/java/com/falkordb/impl/Utils.java#L93-L94
Added lines #L93 - L94 were not covered by tests

---

[warning] 97-97: src/main/java/com/falkordb/impl/Utils.java#L97
Added line #L97 was not covered by tests

---

[warning] 99-100: src/main/java/com/falkordb/impl/Utils.java#L99-L100
Added lines #L99 - L100 were not covered by tests