Cache result of gmod.GetGamemode() in hook.Run

[mgetJane]

hook.Run currently calls gmod.GetGamemode() which is a C call so it's unnecessarily slower than it should be

the function's return value is always equivalent to GAMEMODE or GM

lua_run local s=SysTime() for i=1,1000000 do hook.Run("test") end print(SysTime()-s)
> local s=SysTime() for i=1,1000000 do hook.Run("test") end print(SysTime()-s)...
0.106619362

lua_run function gmod.GetGamemode() return GAMEMODE end
> function gmod.GetGamemode() return GAMEMODE end...

lua_run local s=SysTime() for i=1,1000000 do hook.Run("test") end print(SysTime()-s)
> local s=SysTime() for i=1,1000000 do hook.Run("test") end print(SysTime()-s)...
0.00039914499999583

lua_run local s=SysTime() for i=1,1000000 do hook.Call("test", GAMEMODE) end print(SysTime()-s)
> local s=SysTime() for i=1,1000000 do hook.Call("test", GAMEMODE) end print(SysTime()-s)...
0.00066306600000132

[mgetJane]

also, what does gmod.GetGamemode() even do exactly? why does it need to be a C function?

an alternative to this PR is simply overriding that function with a lua version like so:

function gmod.GetGamemode()
	return GAMEMODE or GM
end

[robotboy655]

I imagine this is its only advantage

[mgetJane]

I imagine this is its only advantage [image]

yeah, code_gs mentioned in the discord that gmod.GetGamemode() ensures you can still get the gamemode table even if the value of GAMEMODE gets changed

imo i would say it's still preferable to have hook.Run use GAMEMODE for the performance boost, since you probably have far bigger problems if some addon decides to set GAMEMODE to a different value

[Astralcircle]

If the method with GAMEMODE is not accepted, then you can do something like this:

local gm_cache

function Run( name, ... )
    if not gm_cache then
        gm_cache = gmod and gmod.GetGamemode() or nil
    end

    return Call( name, gm_cache, ... )
end

[mgetJane]

If the method with GAMEMODE is not accepted, then you can do something like this:

local gm_cache

function Run( name, ... )
    if not gm_cache then
        gm_cache = gmod and gmod.GetGamemode() or nil
    end

    return Call( name, gm_cache, ... )
end

thanks, seems like the best compromise

still not sure why the GAMEMODE variable getting changed is a concern, since that'd completely break everything else anyway