Prevent teardown if in an indirect buffer #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When F* is in an indirect buffer, then killing the indirect buffer causes the base buffer to also undergo a teardown. This commit makes sure to check whether we are actually in the right buffer, before initiating a teardown, thereby preventing spurious teardowns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are in an indirect buffer, killing the indirect buffer causes the base buffer to also undergo a teardown. This commit makes sure to check whether we are actually in the right buffer, before initiating a teardown, thereby preventing spurious teardowns. Only killing the base buffer performs a teardown now with this PR.