Tactics: make splice_t always run without admit/lax #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interactive mode, flycheck queries are run with
lax=truein the environment, which causes SMT queries to be dropped. This in turn will "confuse" the Pulse checker whenever we are doing flychecking, and report spurious errors such as FStarLang/pulse#122.This is a bigger problem with confusion between
--admit_smt_queries true,--lax, and theenv.laxandenv.admitfields. I'm wrapping up a PR about that.Meanwhile, just make all entries into a
splice_ttactic run with admit=false and lax=false.Another thing we should do is simply not flycheck syntax extension blobs. Emacs' fstar-mode does this already, but apparently not the VS code extension. We have an internal environment flag
flychecking:boolfor this purpose, but it's not set from VS code queries apparently.