Normal view #36
Merged
Normal view #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eelucio
reviewed
Jul 28, 2023
There was a problem hiding this comment.
I prefer the result over the facet view.
However, s there a way of changing it without doing it so in the contaienr directly? otherwise I would leave it as facet centered by default (because for example is the one preferred for GEMS) and change it for my xces by hand
|
No, you should NEVER change the container by hand. This is not supposed to work like this. Why is facet view preferred in GEMS? |
|
Since we've had offline LGTM's I am going ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new (facet-centred) view, is not really good as a default. The result-centred view gives a much better overview in my opinion of whats going on. It's good that we can choose. But please let's use the normal view as default.