Allow creator or teacher access to course without enrolment #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityacp
reviewed
Apr 26, 2021
yaksh/views.py
Outdated
| @@ -3185,7 +3185,9 @@ def view_module(request, module_id, course_id, msg=None): | |||
| def course_modules(request, course_id, msg=None): | |||
| user = request.user | |||
| course = Course.objects.get(id=course_id) | |||
| if user not in course.students.all(): | |||
| user_is_not_student = user not in course.students.all() | |||
There was a problem hiding this comment.
Use course.is_student() mehtod.
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=======================================
Coverage 76.69% 76.69%
=======================================
Files 53 53
Lines 7684 7686 +2
Branches 1166 1166
=======================================
+ Hits 5893 5895 +2
Misses 1408 1408
Partials 383 383
Continue to review full report at Codecov.
|
ankitjavalkar
force-pushed
the
creator-crs-enroll
branch
from
d9e5b08
to
8740ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.