Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications app for yaksh #709

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

CruiseDevice
Copy link
Member

@CruiseDevice CruiseDevice commented May 18, 2020

Refer #650

@pep8speaks
Copy link

pep8speaks commented May 18, 2020

Hello @CruiseDevice! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 107:80: E501 line too long (86 > 79 characters)
Line 139:6: W292 no newline at end of file

Line 3356:50: E261 at least two spaces before inline comment
Line 3361:38: W291 trailing whitespace

Comment last updated at 2020-06-11 11:18:52 UTC

notification/tasks.py Outdated Show resolved Hide resolved
notification/tasks.py Outdated Show resolved Hide resolved
notification/tasks.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #709 into master will decrease coverage by 0.36%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage   82.58%   82.22%   -0.37%     
==========================================
  Files          43       48       +5     
  Lines        5812     5851      +39     
  Branches      892      899       +7     
==========================================
+ Hits         4800     4811      +11     
- Misses        696      724      +28     
  Partials      316      316              
Impacted Files Coverage Δ
notification/apps.py 0.00% <0.00%> (ø)
notification/views.py 0.00% <0.00%> (ø)
notification/tasks.py 29.41% <29.41%> (ø)
notification/admin.py 100.00% <100.00%> (ø)
notification/models.py 100.00% <100.00%> (ø)
online_test/celery.py
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aeae2b...9cc2398. Read the comment docs.

notification/tasks.py Outdated Show resolved Hide resolved
 - Use generic relation for subscription model.
 - Create email template.
 - Toggle subscription feature.
 - Move celery crontab configs to settings.py.
 - Model method in course to get quizzes digest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants