Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added working docker configuration, fixed a requirement, added strict… #703

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akshat0047
Copy link

Implemented the following changes to create make the project compatible with docker:

  • Added .dockerignore
  • Edited Dockerfiles to use centos: latest
  • Edited docker-compose.yml to take build a working system, which was broken before
  • Added strict check on env variables in Django Settings, removing the default values creating conflicts in DevOps tasks

@pep8speaks
Copy link

pep8speaks commented May 8, 2020

Hello @akshat0047! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-05 02:57:49 UTC

@akshat0047 akshat0047 force-pushed the master branch 4 times, most recently from d107697 to 1d9fd61 Compare May 8, 2020 23:03
@codecov-commenter
Copy link

Codecov Report

Merging #703 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
- Coverage   81.57%   81.26%   -0.32%     
==========================================
  Files          43       40       -3     
  Lines        6036     5726     -310     
  Branches      921      884      -37     
==========================================
- Hits         4924     4653     -271     
+ Misses        789      741      -48     
- Partials      323      332       +9     
Impacted Files Coverage Δ
yaksh/views.py 71.93% <0.00%> (-1.07%) ⬇️
yaksh/bash_stdio_evaluator.py 80.55% <0.00%> (-0.53%) ⬇️
yaksh/cpp_code_evaluator.py 83.67% <0.00%> (-0.49%) ⬇️
yaksh/java_code_evaluator.py 84.00% <0.00%> (-0.47%) ⬇️
yaksh/hook_evaluator.py 78.43% <0.00%> (-0.42%) ⬇️
yaksh/r_code_evaluator.py 79.41% <0.00%> (-0.30%) ⬇️
yaksh/cpp_stdio_evaluator.py 82.35% <0.00%> (-0.26%) ⬇️
yaksh/grader.py 91.34% <0.00%> (-0.25%) ⬇️
yaksh/bash_code_evaluator.py 78.49% <0.00%> (-0.23%) ⬇️
yaksh/scilab_code_evaluator.py 86.11% <0.00%> (-0.20%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed81054...e9d770c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants