-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py doxygen #539
Draft
Robadob
wants to merge
10
commits into
master
Choose a base branch
from
py_doxygen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Py doxygen #539
Commits on May 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 13824d3 - Browse repository at this point
Copy the full SHA 13824d3View commit details -
Tell swig to keep apidocs in doxygen format.
Haven't actually tested this.
Configuration menu - View commit details
-
Copy full SHA for c835785 - Browse repository at this point
Copy the full SHA c835785View commit details -
Investigated the USE_SWIG module src, there isn't a way to tell it no…
…t to compile the SWIG outputs. Therefore I implmented this which uses a custom command. I cautiously think it works, although will require some refactoring and refinement.
Configuration menu - View commit details
-
Copy full SHA for 801d77f - Browse repository at this point
Copy the full SHA 801d77fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1d7049 - Browse repository at this point
Copy the full SHA e1d7049View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec4d704 - Browse repository at this point
Copy the full SHA ec4d704View commit details -
Configuration menu - View commit details
-
Copy full SHA for 042e369 - Browse repository at this point
Copy the full SHA 042e369View commit details -
Configuration menu - View commit details
-
Copy full SHA for aae15ca - Browse repository at this point
Copy the full SHA aae15caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67f7274 - Browse repository at this point
Copy the full SHA 67f7274View commit details -
Configuration menu - View commit details
-
Copy full SHA for eae5733 - Browse repository at this point
Copy the full SHA eae5733View commit details
Commits on May 24, 2021
-
These changes copy the comments verbatim.
So this kind of works, however there are obvious issues where swig is changing the args. I'm also thinking CI will now die trying to build pyflamegpu, as when I previously had this line in flamegpu.i, it wasn't happy building the cxx.
Configuration menu - View commit details
-
Copy full SHA for 4e5c8ce - Browse repository at this point
Copy the full SHA 4e5c8ceView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.