CI: Manylinux2014 -> Manylinux_2_28 and update deprecated actions #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptheywood
changed the title
This was referenced Sep 4, 2024
ptheywood
force-pushed
the
manylinux_2_28-actions-node-20
branch
from
71c65bc
to
ca0c56f
Compare
…ithub actions Node 16 Github actions are deprecated, but node 20 actions are incompatible with Manylinux_2014/CentOS7. - Replaces manylinux wheel building to use 2_28 (based on Alma 8) - Updates depreacted actions in all workflows.
ptheywood
force-pushed
the
manylinux_2_28-actions-node-20
branch
from
ca0c56f
to
943e244
Compare
|
Wheels generated by the Manylinux_2_28 wheel seem to be missing some wrapped methods. Will need to investiagate when a bit more when on a machine with a GPU. |
This will be due to swig 4.2.1 being included in the manylinux_2_28 containers. Could downgrade (and block swig 4.2?), but it would be better to fix the root cause (i.e. make pyflamegpu swig 4.2 compatible). See #956 |
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 16 Github actions are deprecated, but node 20 actions are incompatible with Manylinux_2014/CentOS7.
Produced wheels are still not technically Manylinux compliant due to linkage against non-packaged .so files (see #647)
This will reduce wheel compatibility, by increasing the required glibc to 2.28 or newer.
Closes #1190
Closes #1224
Replaces #1200 and #1194 as they must be coupled.
Todo
The use of download_artifact will not have been tested by CI, as it is only used if a version tag is created. We might want to do a dry run on a fork.