-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight strings in Context values #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This provides some nice consistency to the Context
keyword values. I like the highlighted commas too.
One other thought I had, which is definitely just a question and not something that necessarily has to change, is that Context
is now the only keyword that might not have any highlight/change in color. I tried changing some of the "name"s locally just to see how it would look, and I'm actually not sure if I like it, but I wanted to mention it to see if you had already considered it or what you think. I included a screenshot below:
Co-authored-by: Julia Afeltra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new updates look good to me! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmoesel I managed to make a small improvement that handles the case you posted. There are still some cases that aren't handled (please don't start your line with a comma), but it's pretty usable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @mint-thompson! Thank you!
Completes task CIMPL-1114.
Try it out with some FSH with lots of Context keywords to see how you feel about these highlights. FHIRPath strings get the usual double-quote style applied. Other contexts don't get any particular style applied. The
,
token is highlighted, which should be helpful, but might also be distracting? I kind of like it, though.