Transaction.decode/1 #100
Draft
Transaction.decode/1 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haven't forgotten this. just busy... i'll get there got some time today and sketched out what a type2 decode may look like, assuming it returns a tx struct. i'll flush out the test on my next go-round |
robrobbins
commented
Apr 11, 2024
|
|
||
| {:ok, public_key} = ExSecp256k1.recover(tx_hash, r, s, :binary.decode_unsigned(y)) | ||
|
|
||
| {:ok, struct!(__MODULE__, %{ |
There was a problem hiding this comment.
@alisinabh i'm assuming we want to return a transaction struct from decode/1
There was a problem hiding this comment.
Hey, Sorry I somehow missed this.
Yes it should.
Do you still want to work on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just getting started here. Will spend a few hours each working day if possible getting it done. Shouldn't take too long as we already have a working case in my day job at Coinlist (for legacy, will be adding 1559 next week)
Will remain in draft as i like to psuedocode and comment to discuss before going down a path too far