Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @vscode/vsce to devDependencies #126

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Add @vscode/vsce to devDependencies #126

merged 1 commit into from
Mar 30, 2024

Conversation

samestep
Copy link
Contributor

Currently, running

npm install
npm run package

fails if one does not already have @vscode/vsce globally installed for some reason. This PR adds it to package.json so the above commands work as expected.

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I do think most people planning to develop a VS Code extension would already have it installed globally, it doesn't hurt to list it explicitly like this in case they do not.

@jryans jryans merged commit facc3d4 into Eugleo:master Mar 30, 2024
4 checks passed
@samestep
Copy link
Contributor Author

While I do think most people planning to develop a VS Code extension would already have it installed globally, it doesn't hurt to list it explicitly like this in case they do not.

I suppose, since I often see this in repos for VS Code extensions, but I work on several VS Code extensions and generally prefer not to install npm packages globally.

Anyways, thanks for merging this!

@samestep samestep deleted the vsce-dependency branch March 30, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants