Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host: Fix RFNoC graph action queue lockup on action exceptions #730

Closed
wants to merge 1 commit into from
Closed

host: Fix RFNoC graph action queue lockup on action exceptions #730

wants to merge 1 commit into from

Commits on Feb 19, 2024

  1. host: Fix RFNoC graph action queue lockup on action exceptions 

    Processing of the action queue gets locked up when any action
being executed in the send_action call throws an exception.
Exceptions are not caught in the loop handling the action queue,
resulting in the handling_ongoing queue locking flag to never
be released. Any subsequent call to enqueue_action will return
on the early exit with the assumption that we're already handling
the actions, yet the previous handler exited with an exception.

This fix uses a RAII wrapper rather than a manually claimed and
released atomic flag to ensure that the handling_ongoing will be
released even under exceptional conditions.
    @hannodewind
    hannodewind committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0d68db5 View commit details
    Browse the repository at this point in the history