Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: geocoder demo on windows #1140 #1177

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: geocoder demo on windows #1140 #1177

merged 2 commits into from
Oct 17, 2024

Conversation

BrunoCaimar
Copy link
Contributor

@BrunoCaimar BrunoCaimar commented Oct 10, 2024 •
edited
Loading

@BrunoCaimar BrunoCaimar changed the title Fix geocoder demo on windows #1140 fix: geocoder demo on windows #1140 Oct 11, 2024
@gavinr-maps gavinr-maps self-requested a review October 14, 2024 14:00
@gavinr-maps
Copy link
Contributor

@BrunoCaimar thanks for the PR! I will test this shortly and reply with any feedback.

gavinr-maps
gavinr-maps approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@gavinr-maps gavinr-maps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me on Windows! Looks good from that perspective.

I'd like for someone on a Mac to also test to make sure it still works there.

@BrunoCaimar
Copy link
Contributor Author

I`ve tested it on a Mac and it works fine. I can provide some screenshots if needed.

@hhkaos
Copy link
Member

hhkaos commented Oct 16, 2024 •
edited
Loading

Update:

Sorry, I previously tried in the wrong demo. The attachments browser is working on my machine ;D:
Screenshot 2024-10-16 at 15 03 51

I'm on a MacOS Sonoma 14.6.1

patrickarlt
patrickarlt approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I was able to run the Vite demo locally on my Mac

@gavinr-maps gavinr-maps merged commit bfd7ce9 into Esri:main Oct 17, 2024
2 checks passed
@BrunoCaimar BrunoCaimar deleted the fix_geocoder_demo_on_windows branch October 22, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinr-maps gavinr-maps gavinr-maps approved these changes

@patrickarlt patrickarlt patrickarlt approved these changes

Assignees

@patrickarlt patrickarlt

@gavinr-maps gavinr-maps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue running demos on Windows (path/rootDir issue)
4 participants
@BrunoCaimar @gavinr-maps @hhkaos @patrickarlt