Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update notebook image for v2.4.0 #2093

Merged
merged 2 commits into from
Oct 2, 2024
Merged

update notebook image for v2.4.0 #2093

merged 2 commits into from
Oct 2, 2024

Conversation

jtroe
Copy link
Collaborator

@jtroe jtroe commented Oct 2, 2024

Updates notebook image for v2.4.0 (and a fix we'll redeploy to v2.3.x)

  • Creates new conda environment to remove dependency on conda-forge
  • use minimal base image for more builtin tooling (removes step to install unzip)
  • set default version to 2.4.0
  • pivot notebooks vs lab on the 2.4.0 release to allow new builds of previous versions
  • set default environment to "arcgis"

@jtroe
Copy link
Collaborator Author

jtroe commented Oct 2, 2024 •
edited
Loading

test builds:
https://github.com/Esri/arcgis-python-api/actions/runs/11147555834 ✅
https://github.com/Esri/arcgis-python-api/actions/runs/11148049113 ✅
https://github.com/Esri/arcgis-python-api/actions/runs/11148051880 ✅

jyaistMap
jyaistMap approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@jyaistMap jyaistMap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled image and ran - connection and map widget testing passed

@jtroe jtroe merged commit 82bd732 into master Oct 2, 2024
4 checks passed
@jtroe jtroe deleted the jtroe/docker-2.4.0 branch October 2, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyaistMap jyaistMap jyaistMap approved these changes

@achapkowski achapkowski Awaiting requested review from achapkowski

@tarunkukreja003 tarunkukreja003 Awaiting requested review from tarunkukreja003

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtroe @jyaistMap