Bump repmgr version 5.5.0 #868
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmarques
requested changes
Nov 6, 2024
| #define REPMGR_VERSION_NUM 50400 | ||
| #define REPMGR_EXTENSION_VERSION "5.4" | ||
| #define REPMGR_EXTENSION_NUM 50400 | ||
| #define REPMGR_RELEASE_DATE "2022-XX-XX" |
There was a problem hiding this comment.
I believe the XX are needed. Check the Makefiles
There was a problem hiding this comment.
If I understand, that variable affects only what we put in https://www.repmgr.org/docs/5.3/install-requirements.html, in the "current" release.
I haven't found it in any other place, maybe we just added the "XX-XX" because we didn't know in advance when a new released would be publised?
If we keep the Xs, we would see this
$ awk '/^#define REPMGR_RELEASE_DATE / { print $3; }' repmgr_version.h.in | cut -d '"' -f 2
2024-XX-XX
I'll generate the docs to discard.
|
It's missing a repmgr--5.4-5.5.sql file for the upgrade of the extension |
gonzalemario
force-pushed
the
dev/v5.5.0
branch
from
f8d4c27
to
3d7bd60
Compare
gonzalemario
force-pushed
the
dev/v5.5.0
branch
from
3d7bd60
to
4e5246f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.