Rc june 2024 #92
Merged
Rc june 2024 #92
Commits on Jun 28, 2024
-
-
`pyright` was complaining about the `exec_diagnose`. That issue occurs because based on the Barman module version that is installed in the virtual environemnt, the signature of that method would have either 2 or 4 parameters. We had 2 options to handle that issue: * Add `pyright: ignore` directives to the source code where `exec_diagnose` is called; or * Change the implementation so instead of relying on `AttributeError` exception, it would handle the version for the Barman module. We chose the first option for now, so we unblock the release. The code with `AttributeError` exception has already been tested. If we were to go with the second option now, that would require changing the code, changing the unit tests and performing more tests, thus dealying the release. Signed-off-by: Israel Barth Rubio <[email protected]>
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.