Add aws irsa auth #1021
Open
Add aws irsa auth #1021
+52
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcalacoci
reviewed
Nov 4, 2024
| @@ -102,6 +103,7 @@ def __init__( | |||
| self, | |||
| url, | |||
| encryption=None, | |||
| aws_irsa=False, | |||
There was a problem hiding this comment.
please relocate this new argument at the end of the argument list to preserve the original signature @smcaine
|
@smcaine thanks for your contribution. I've put a suggestion in the code during my review of the pr. The code seems correct but your patch has broken the Unit Tests for Barman, because of this we cannot merge the PR as it is. Could you fix the failing tests? FYI we are working on some contribution guidelines for PRs and what I'm asking will be part of this new documentation section. Thanks. |
smcaine
force-pushed
the
add-aws-irsa-auth
branch
from
181e3bb
to
f6c55a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this flag to use the service account iam role. Using aws access keys is bad practice and typically prohibited in most production environments.
This relates to issue i raised #949