-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackathon/dec23 #272
Hackathon/dec23 #272
Conversation
Alternative approach to mock sqlalchemy engine for unittests
Update tests tree structure and docstrings
Hackathon/dec23
Co-authored-by: J. Alvarez-Jarreta <[email protected]>
Co-authored-by: J. Alvarez-Jarreta <[email protected]>
Mbarba/hack/fix fasta tests
Co-authored-by: Matthieu Barba <[email protected]>
Co-authored-by: Matthieu Barba <[email protected]>
Disha/genbank test update
Co-authored-by: J. Alvarez-Jarreta <[email protected]>
GFF3 modules tests
Add genome stats comparison tests
Resolve conflict to prepare merging hackathon/dec23 to main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A net 1700+ new lines to include the first iteration of unit tests, increasing our coverage from 11% to 19%... Well done everyone!
Coverage information of the modules updated:
Module | statements | missing | excluded | branches | partial | coverage |
---|---|---|---|---|---|---|
fasta/__init__.py | 2 | 0 | 0 | 0 | 0 | 100% |
fasta/process.py | 42 | 1 | 11 | 18 | 1 | 97% |
genbank/__init__.py | 3 | 0 | 0 | 0 | 0 | 100% |
genbank/download.py | 23 | 0 | 11 | 2 | 0 | 100% |
genbank/extract_data.py | 249 | 211 | 14 | 94 | 0 | 11% |
genome_stats/__init__.py | 3 | 0 | 0 | 0 | 0 | 100% |
genome_stats/compare.py | 68 | 0 | 10 | 24 | 0 | 100% |
genome_stats/dump.py | 57 | 38 | 14 | 8 | 0 | 29% |
gff3/__init__.py | 5 | 0 | 0 | 0 | 0 | 100% |
gff3/extract_annotation.py | 101 | 8 | 0 | 34 | 2 | 91% |
gff3/gene_merger.py | 69 | 8 | 0 | 24 | 3 | 86% |
gff3/process.py | 7 | 0 | 28 | 0 | 0 | 100% |
gff3/simplifier.py | 444 | 385 | 0 | 218 | 0 | 9% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extensive work so well done to all ! Im happy to approve
Fix GFF3 parsing for naked transcripts and CDSs
All hackathon commits from December 2023, adding lots of unit testing, with some code refactoring.