Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mbarba/fix integrity #270

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Mbarba/fix integrity #270

merged 2 commits into from
Jan 18, 2024

Conversation

MatBarba
Copy link
Contributor

A silent bug in the integrity check where the GFF3 comparison was not done because we used wrong keys.

I've fixed it and added some failchecks.

Copy link
Contributor

@JAlvarezJarreta JAlvarezJarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@JAlvarezJarreta JAlvarezJarreta merged commit 19072d9 into main Jan 18, 2024
1 check passed
@JAlvarezJarreta JAlvarezJarreta deleted the mbarba/fix_integrity branch January 23, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants